-
Notifications
You must be signed in to change notification settings - Fork 853
devel: fixed the missed changes to plan after agency callback is registred f… #4775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
neunhoef
merged 20 commits into
devel
from
bug-fix/create-collection-coordinator-changes-to-plan-ignored-after-callbak-registry
Mar 14, 2018
Merged
devel: fixed the missed changes to plan after agency callback is registred f… #4775
neunhoef
merged 20 commits into
devel
from
bug-fix/create-collection-coordinator-changes-to-plan-ignored-after-callbak-registry
Mar 14, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or create collection
…or create collection
…ction-coordinator-changes-to-plan-ignored-after-callbak-registry
…ction-coordinator-changes-to-plan-ignored-after-callbak-registry
…-fix/create-collection-coordinator-changes-to-plan-ignored-after-callbak-registry
…ction-coordinator-changes-to-plan-ignored-after-callbak-registry
…gnored-after-callbak-registry' of https://github.com/arangodb/arangodb into bug-fix/create-collection-coordinator-changes-to-plan-ignored-after-callbak-registry
…-fix/create-collection-coordinator-changes-to-plan-ignored-after-callbak-registry
neunhoef
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Passes tests as good as devel. We had one other cluster start bug but this is due to something else and will be dealt with separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or create collection
Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.