8000 fixed issue #4185: On execution of FULLTEXT search / AQL query db is … by jsteemann · Pull Request #4239 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

fixed issue #4185: On execution of FULLTEXT search / AQL query db is … #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 15, 2018
Merged

fixed issue #4185: On execution of FULLTEXT search / AQL query db is … #4239

merged 5 commits into from
Jan 15, 2018

Conversation

jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jan 5, 2018 •
edited
Loading

…restarting

@jsteemann jsteemann added this to the 3.3 milestone Jan 5, 2018
@jsteemann jsteemann mentioned this pull request Jan 5, 2018
Closed
29 tasks
@graetzer graetzer self-assigned this Jan 5, 2018
graetzer
graetzer reviewed Jan 5, 2018
View reviewed changes
arangod/MMFiles/MMFilesAqlFunctions.cpp Outdated
@@ -412,7 +412,7 @@ void MMFilesAqlFunctions::registerResources() {
TRI_ASSERT(functions != nullptr);

// fulltext functions
functions->add({"FULLTEXT", ".h,.,.|.", true, false,
functions->add({"FULLTEXT", ".h,.,.|.", false, false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in this case the FULLTEXT calculation node is not removed !??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not in all cases. But I prefer stability or optimization in just some cases but crashes in others.

@jsteemann
Copy link
Contributor Author

With the latest version, the following test in shell_server_aql fails:

   [FAILED]  js/server/tests/aql/aql-optimizer-fulltext.js

      "testRuleBasics" failed: at assertion #1: FOR d IN FULLTEXT(@@coll, @attr, 'prefix:möchten,müller') SORT d.id RETURN d.id Has IndexNode: (1) is not equal to (0)
(Error
    at assertEqual (js/common/modules/jsunity/jsunity.js:103:19)
    at hasIndexNode (js/server/tests/aql/aql-optimizer-fulltext.js:63:5)
    at forEach.field (js/server/tests/aql/aql-optimizer-fulltext.js:132:13)
    at Array.forEach (native)
    at checkQuery (js/server/tests/aql/aql-optimizer-fulltext.js:128:32)
    at Object.testRuleBasics (js/server/tests/aql/aql-optimizer-fulltext.js:146:7)
    at Object.run (js/common/modules/jsunity/jsunity.js:515:23)
    at Object.Run [as run] (js/common/modules/jsunity.js:145:24)
    at js/server/tests/aql/aql-optimizer-fulltext.js:164:9
    at js/server/tests/aql/aql-optimizer-fulltext.js:167:2)

@jsteemann jsteemann merged commit f31734a into 3.3 Jan 15, 2018
@arangodb-release-bot arangodb-release-bot deleted the bug-fix-3.3/fix-issue-4185 branch February 16, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graetzer graetzer graetzer left review comments

Assignees

@graetzer graetzer

Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteemann @graetzer
0