8000 Make rocksdb portable on windows by default by m0ppers · Pull Request #2972 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Make rocksdb portable on windows by default #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Make rocksdb portable on windows by default #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 3rdParty/rocksdb/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ endif ()
# snappy settings
#set(SNAPPY_HOME ${CMAKE_SOURCE_DIR}/3rdParty/snappy/google-snappy-d53de18/)

if (WIN32)
option(PORTABLE_ROCKSDB "enable portable rocksdb build (disabling might yield better performance but break portability)" On)
set(PORTABLE ${PORTABLE_ROCKSDB})
endif ()
#if (WIN32)
# set(SNAPPY 1 CACHE BOOL "enable snappy")
# set(SNAPPY_INCLUDE ${SNAPPY_HOME};${CMAKE_BINARY_DIR}/3rdParty/snappy/google-snappy-d53de18/)
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ devel

* option "--rocksdb.compaction-read-ahead-size" now defaults to 2MB

* change windows build so that rocksdb doesn't enforce AVX optimizations by default

v3.2.0 (2017-07-20)
-------------------
Expand Down
0