8000 Fix OpenMP failure on ARM by jbajic · Pull Request #21772 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix OpenMP failure on ARM #21772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Jun 2, 2025
Merged

Fix OpenMP failure on ARM #21772

Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
6e76df9
Reduce OMP threading
jbajic Apr 3, 2025
dcae2c5
Disable kmp affinity
jbajic Apr 3, 2025
9627409
Disable on openmp
jbajic Apr 3, 2025
bcab65f
Disable KMP_AFFINITY and LIBOMP_AFFINITY
jbajic Apr 4, 2025
9699c84
Reduce omp number of threads
jbajic Apr 4, 2025
8a6e620
Print cpu stats
jbajic Apr 4, 2025
d5b8823
Use KMP_DEVICE_THREAD_LIMIT
jbajic Apr 4, 2025
bf0c5a1
More verbose
jbajic Apr 4, 2025
794011e
Check restore env
jbajic Apr 14, 2025
d565324
Update env variables
jbajic Apr 14, 2025
f5cec0b
Merge branch 'devel' into fix/arm-failure
jbajic Apr 14, 2025
76ba626
Enable tests
jbajic Apr 14, 2025
b884a99
Enable vector index tests
jbajic Apr 14, 2025
9d81206
Clear string
jbajic Apr 14, 2025
02fd177
Print omp variables
jbajic Apr 14, 2025
83d1504
Fix dependency
jbajic Apr 14, 2025
cc938a4
Add flags only for arm
jbajic Apr 15, 2025
d03933e
Fix arch var
jbajic Apr 15, 2025
1870ad1
Refactor
jbajic Apr 16, 2025
8661867
Merge branch 'devel' into fix/arm-failure
jbajic May 12, 2025
8360527
Fix
jbajic May 12, 2025
abfa5d5
Disable kmp
jbajic May 12, 2025
0f0d8d1
Try testing libomp
jbajic May 13, 2025
4c941ae
Clone arangod for testing
jbajic May 13, 2025
13457e1
Clone arango
jbajic May 13, 2025
14e555b
Fix path
jbajic May 13, 2025
5741da6
Fix
jbajic May 13, 2025
25468b4
Remove verbose
jbajic May 13, 2025
045c48f
Remove test changes
jbajic May 13, 2025
141d9b5
Check env
jbajic May 13, 2025
309ee83
Merge branch 'devel' into fix/arm-failure
jbajic May 13, 2025
9530ce1
Test env
jbajic May 14, 2025
0314bac
Always set env
jbajic May 15, 2025
7674b4c
Disable dynamic
jbajic May 15, 2025
9de436f
Add preload
jbajic May 15, 2025
141d338
Define cpu topology
jbajic May 19, 2025
74d1034
Test out sample
jbajic May 19, 2025
f4f6231
Try out libgomp
jbajic May 19, 2025
109b270
Use libgomp
jbajic May 20, 2025
dda4ffb
Enable flags
jbajic May 20, 2025
920e989
Fix arm
jbajic May 20, 2025
95230ad
Fix typo
jbajic May 20, 2025
397f315
Fix
jbajic May 20, 2025
6c958c0
Clean CMakeLists
jbajic May 20, 2025
47d4e4e
Remove redundant
jbajic May 20, 2025
1e698ea
Merge branch 'devel' into bug-fix/fix-openmp-arm-failure
jbajic May 20, 2025
62e81f5
Remove dumpEnv
jbajic May 20, 2025
e8b6613
Remove print
jbajic May 20, 2025
bf6df78
Add comment
jbajic May 20, 2025
9fe9e3d
Merge branch 'devel' into bug-fix/fix-openmp-arm-failure
jbajic May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable kmp affinity
  • Loading branch information
@jbajic
jbajic committed Apr 3, 2025
commit dcae2c57fe97e50151dbf1fbd9cca3e7fdbfeec9
13 changes: 5 additions & 8 deletions .circleci/base_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,9 +545,8 @@ jobs:
if command -v promtool &> /dev/null; then
export PROMTOOL_PATH=`command -v promtool`
fi
# Fix arm failing in faiss https://github.com/llvm/llvm-project/issues/49923
export LIBOMP_USE_HIDDEN_HELPER_TASK=0
export LIBOMP_NUM_HIDDEN_HELPER_THREADS=0
# Fix arm failing in faiss
export KMP_AFFINITY=disabled

export TIMELIMIT=<< parameters.timeLimit >>
# Note: we need the leading space for extraArgs to avoid a parsing issue in argparse
Expand Down Expand Up @@ -590,8 +589,7 @@ jobs:
name: Run HotBackup tests
command: |
# Fix arm failing in faiss https://github.com/llvm/llvm-project/issues/49923
export LIBOMP_USE_HIDDEN_HELPER_TASK=0
export LIBOMP_NUM_HIDDEN_HELPER_THREADS=0
export KMP_AFFINITY=disabled

python3 scripts/toolbox/HotBackupConsistencyTest.py \
--arangod $PWD/build/bin/arangod \
Expand Down Expand Up @@ -644,9 +642,8 @@ jobs:
no_output_timeout: 20m
command: |
pwd
# Fix arm failing in faiss https://github.com/llvm/llvm-project/issues/49923
export LIBOMP_USE_HIDDEN_HELPER_TASK=0
export LIBOMP_NUM_HIDDEN_HELPER_THREADS=0
# Fix arm failing in faiss https://github.com/llvm/llvm-project/issues/49923
export KMP_AFFINITY=disabled

export SOURCE=nightlypublic
export RTA_EDITION=<< parameters.enterprise >>
Expand Down
0