Move async task cleanup before transaction destruction #21734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
reviewed
May 21, 2025
| for (auto it = _blocks.rbegin(); it != _blocks.rend(); ++it) { | ||
| (*it)->stopAsyncTasks(); | ||
| } | ||
| stopAsyncTasks(); |
There was a problem hiding this comment.
Suggested change
| stopAsyncTasks(); |
This can and should be deleted now, or am I overlooking something?
There was a problem hiding this comment.
I agree, but I think in practice this will just call the stopAsyncTasks and should do nothing since there should be no async task to loop through.
But that is built under the assumption that the ExecutionEngine dtor will always be called after we have cleaned up the async tasks. That's why I deliberately left it, since it should be the responsibility of ExecutionEngine to do its own cleanup, and if somebody else did it before, that is also fine. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Move the cleanup of async prefetch tasks before we invalidate the transaction, since there might be a possibility that some async prefetch tasks might use the transaction object.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)