8000 Add tests for async registry pretty printer by jvolmer · Pull Request #21720 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Add tests for async registry pretty printer #21720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 26, 2025
Merged

Add tests for async registry pretty printer #21720

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5cd77ac
Promise snapshot shows running thread instead of owning thread
jvolmer May 19, 2025
9370897
Fix pretty printers
jvolmer May 19, 2025
df8264b
Add a gdb integration test skeleton
jvolmer Feb 12, 2025
f1a8936
Print out variables
jvolmer Feb 12, 2025
08ed1b1
Create a registry inside the test
jvolmer Feb 14, 2025
8e1b076
Add first real test (empty registry)
jvolmer Feb 20, 2025
b7785c7
Add tests and fix small bugs in stacktrace printing
jvolmer Apr 15, 2025
0230a09
Move all tests to tests dir and use ctest for pretty-print testing
jvolmer Apr 17, 2025
c6a4f15
Test running thread variable
jvolmer May 19, 2025
e8153a9
Merge remote-tracking branch 'origin/devel' into feature/add-tests-fo…
jvolmer May 21, 2025
6e68223
Fix linter
jvolmer May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test running thread variable
  • Loading branch information
@jvolmer
jvolmer committed May 19, 2025
commit c6a4f1579d1950a5143b1ac9acc509111b193fcb
29 changes: 24 additions & 5 deletions ...ncRegistryServer/PrettyPrinter/gdb_integration/async_registry_gdb_pretty_printer_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,18 @@ using namespace arangodb::async_registry;
auto breakpoint() { raise(SIGINT); }

auto format(PromiseSnapshot const& snapshot) -> std::string {
return fmt::format("\"{}\" (\"{}\":{}), thread {}, {}",
snapshot.source_location.function_name,
snapshot.source_location.file_name,
snapshot.source_location.line, snapshot.thread.kernel_id,
arangodb::inspection::json(snapshot.state));
if (snapshot.thread == std::nullopt) {
return fmt::format(
"\"{}\" (\"{}\":{}), {}", snapshot.source_location.function_name,
snapshot.source_location.file_name, snapshot.source_location.line,
arangodb::inspection::json(snapshot.state));
} else {
return fmt::format(
"\"{}\" (\"{}\":{}), {} on thread {}",
snapshot.source_location.function_name,
snapshot.source_location.file_name, snapshot.source_location.line,
arangodb::inspection::json(snapshot.state), snapshot.thread->kernel_id);
}
}

/**
Expand Down Expand Up @@ -79,6 +86,18 @@ int main() {

breakpoint();

// works also with a currently non-running promise
parent->data.running_thread.store(std::nullopt);
expected = fmt::format(
"async registry = {{\n"
"[thread {}] = \n"
" ┌ {}\n"
"─ thread {}}}",
current_thread.kernel_id, format(parent->data.snapshot()),
current_thread.kernel_id);

breakpoint();
< 48A3 br>
// add a promise that depends on parent promise
auto* child = thread_registry->add([&]() {
return Promise{{parent->data.id()}, std::source_location::current()};
Expand Down
0