8000 fix ASan errors in test by jsteemann · Pull Request #20861 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

fix ASan errors in test #20861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to 8000 your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix ASan errors in test #20861

merged 2 commits into from
Apr 23, 2024

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Fix ASan errors in test.
Should fix the following test error with sanitizers enabled:

[FAILED]  tests/js/client/shell/shell-verify-sst-noncluster.js

  "testVerify" failed: Error: at assertion #6: {
  "pid" : 896,
  "status" : "TERMINATED",
  "exit" : 1
}: (1) is not equal to (0)
(Error
    at verifySsts (tests/js/client/shell/shell-verify-sst-noncluster.js:106:9)
    at tests/js/client/shell/shell-verify-sst-noncluster.js:116:11
    at Object.testVerify (tests/js/client/shell/shell-verify-sst-noncluster.js:111:12)
....    at Object.shellClient [as shell_client] (/root/project/js/client/modules/@arangodb/testsuites/aql.js:209:79)
 - test failed
  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@jsteemann
fix ASan errors in test
c9b0fc1 
should fix the following test error with sanitizers enabled:

    [FAILED]  tests/js/client/shell/shell-verify-sst-noncluster.js

      "testVerify" failed: Error: at assertion #6: {
  "pid" : 896,
  "status" : "TERMINATED",
  "exit" : 1
}: (1) is not equal to (0)
(Error
    at verify
8000
Ssts (tests/js/client/shell/shell-verify-sst-noncluster.js:106:9)
    at tests/js/client/shell/shell-verify-sst-noncluster.js:116:11
    at Object.testVerify (tests/js/client/shell/shell-verify-sst-noncluster.js:111:12)
....    at Object.shellClient [as shell_client] (/root/project/js/client/modules/@arangodb/testsuites/aql.js:209:79)
 - test failed
@jsteemann jsteemann added this to the devel milestone Apr 23, 2024
@jsteemann jsteemann requested a review from a team as a code owner April 23, 2024 11:21
@cla-bot cla-bot bot added the cla-signed label Apr 23, 2024
@maierlars maierlars merged commit c7b7804 into devel Apr 23, 2024
6 checks passed
@maierlars maierlars deleted the bug-fix/fix-asan-errors-in-test branch April 23, 2024 13:44
@jsteemann jsteemann mentioned this pull request May 7, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoeter mpoeter 59DE mpoeter approved these changes

@maierlars maierlars maierlars approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @mpoeter @maierlars
0