8000 APM-786 heap sort with stored values by Dronplane · Pull Request #19551 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

APM-786 heap sort with stored values #19551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 14, 2023
Merged

APM-786 heap sort with stored values #19551

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
07b591f
wip
Dronplane Apr 25, 2023
899331c
wip
Dronplane Apr 26, 2023
a03e71e
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Jul 18, 2023
a1ea685
wip
Dronplane Jul 18, 2023
b1ba920
wip
Dronplane Aug 1, 2023
8e392ce
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 1, 2023
4584827
wip
Dronplane Aug 1, 2023
13d90f3
wip
Dronplane Aug 1, 2023
f62a7d5
wip
Dronplane Aug 3, 2023
dc44497
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 3, 2023
48442bc
wip
Dronplane Aug 7, 2023
c2a0b23
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 7, 2023
6995111
wip
Dronplane Aug 8, 2023
3227d21
wip
Dronplane Aug 8, 2023
de064a2
wip
Dronplane Aug 9, 2023
022d9da
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 9, 2023
9599662
wip
Dronplane Aug 9, 2023
8f8acff
fixex for postfix case
Dronplane Aug 9, 2023
e53f502
cleanup
Dronplane Aug 9, 2023
e7589a9
fix build
Dronplane Aug 10, 2023
7227454
fix
Dronplane Aug 10, 2023
0b91f37
fix typename
Dronplane Aug 10, 2023
0cdf93b
clang-format
Dronplane Aug 10, 2023
a47eb93
add explicit inits
Dronplane Aug 10, 2023
b56a4ec
fix
Dronplane Aug 10, 2023
e4fc95a
review comments
Dronplane Aug 10, 2023
34b8946
get rid of values mapping
Dronplane Aug 11, 2023
3504ef2
remove redundant inits
Dronplane Aug 11, 2023
9b8f84f
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 11, 2023
9db2616
fix empty field case
Dronplane Aug 11, 2023
ec8b7b1
fix tests
Dronplane Aug 11, 2023
40dbd9e
Merge remote-tracking branch 'origin/devel' into feature/APM-786-heap…
Dronplane Aug 11, 2023
b1c9e09
fix asan build + fix slice iteration
Dronplane Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typename
  • Loading branch information
@Dronplane
Dronplane committed Aug 10, 2023
commit 0b91f379bff67a11e4c2e70d0c8bf69cdd9d65db
3 changes: 2 additions & 1 deletion arangod/Aql/IResearchViewExecutor.tpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,8 @@ bool IResearchViewExecutorBase<Impl, ExecutionTraits>::getStoredValuesReaders(
auto index = storedValuesIndex * columnsFieldsRegs.size();
if (IResearchViewNode::kSortColumnNumber == columnFieldsRegs->first) {
if (!std::is_same_v<HeapSortExecutorValue,
typename Traits::IndexBufferValueType> ||
typename arangodb::aql::IResearchViewExecutorBase<
Impl, ExecutionTraits>::Traits::IndexBufferValueType> ||
!_storedColumnsMask.contains(columnFieldsRegs->first)) {
auto sortReader = ::sortColumn(segmentReader);
if (ADB_UNLIKELY(!sortReader)) {
Expand Down
0