APM-786 heap sort with stored values #19551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sort-stored-values
…-sort-stored-values
…-sort-stored-values
…-sort-stored-values
…-sort-stored-values
MBkkt
reviewed
Aug 9, 2023
MBkkt
reviewed
Aug 10, 2023
MBkkt
reviewed
Aug 10, 2023
MBkkt
reviewed
Aug 10, 2023
MBkkt
reviewed
Aug 10, 2023
| @@ -130,51 +130,101 @@ lookupCollection(arangodb::transaction::Methods& trx, DataSourceId cid, | |||
| } | |||
| } | |||
|
|
|||
| constexpr int kSortMultiplier[]{-1, 1}; | |||
There was a problem hiding this comment.
Suggested change
| constexpr int kSortMultiplier[]{-1, 1}; | |
| inline constexpr int kSortMultiplier[]{-1, 1}; |
…-sort-stored-values
…-sort-stored-values
MBkkt
reviewed
Aug 11, 2023
| void setScoresSort(std::span<std::pair<size_t, bool> const> s) noexcept { | ||
| _scoresSort = s; | ||
| void setHeapSort(std::span<iresearch::HeapSortElement const> s, | ||
| iresearch::IResearchViewNode::ViewValuesRegisters const& |
There was a problem hiding this comment.
Could we make it "flat_map"/just sorted vector of pairs?
There was a problem hiding this comment.
We can think about this. But let's do it in a separate PR as this one is already big enough.
MBkkt
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Adds ability to use constrained heap optimization for view queries with using stored values/primary sort
Enterprise PR: https://github.com/arangodb/enterprise/pull/1349
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)