8000 SEARCH-279 snapshot for inverted index by Dronplane · Pull Request #18128 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

SEARCH-279 snapshot for inverted index #18128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
cc68456
make inverted index read docs from custom snapshot
Dronplane Jan 24, 2023
25f6498
wip - adding late materialization snapshot
Dronplane Jan 27, 2023
df30a6f
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 6, 2023
6ad9c5c
wip
Dronplane Feb 8, 2023
9618cf5
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 8, 2023
c381636
wip
Dronplane Feb 8, 2023
64b2af9
switch inverted index to viewsnapshot
Dronplane Feb 10, 2023
c59db0d
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 10, 2023
f26ed9e
fix
Dronplane Feb 10, 2023
d871f9c
wip
Dronplane Feb 13, 2023
754d9b5
wip
Dronplane Feb 13, 2023
82257e2
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 13, 2023
cb6e02c
try to fix mac build
Dronplane Feb 14, 2023
7a2b17c
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 14, 2023
d24f85d
fix tests build
Dronplane Feb 14, 2023
a28e2c5
add explicit instantiations
Dronplane Feb 14, 2023
04b2f29
add test
Dronplane Feb 14, 2023
f73d376
fix issue
Dronplane Feb 15, 2023
41754b9
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 15, 2023
29629f6
add js tests
Dronplane Feb 16, 2023
833c507
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 16, 2023
b38c3e8
clang-format
Dronplane Feb 16, 2023
419f3b3
cleanup
Dronplane Feb 16, 2023
d6e4e49
adress review comments
Dronplane Feb 16, 2023
76d2de6
fix for cluster
Dronplane Feb 16, 2023
a4958ce
Merge remote-tracking branch 'origin/devel' into feature/SEARCH-279-s…
Dronplane Feb 16, 2023
ee277a9
review comments
Dronplane Feb 16, 2023
9306ddb
jslint
Dronplane Feb 16, 2023
0ed94e3
Merge branch 'devel' into feature/SEARCH-279-snapshot-for-inverted-index
Dronplane Feb 17, 2023
94bf50c
cleanup
Dronplane Feb 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
Dronplane committed Feb 16, 2023
commit 419f3b3bb0271e0a462afb39b91fb17c8907a448
4 changes: 2 additions & 2 deletions arangod/Aql/IndexNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ IndexNode::IndexNode(
_options(opts),
_outNonMaterializedDocId(nullptr) {
TRI_ASSERT(_condition != nullptr);

prepareProjections();
}

Expand Down Expand Up @@ -353,9 +354,7 @@ std::unique_ptr<ExecutionBlock> IndexNode::createBlock(

auto const outVariable =
isLateMaterialized() ? _outNonMaterializedDocId : _outVariable;

auto const outRegister = variableToRegisterId(outVariable);

auto numIndVarsRegisters =
static_cast<aql::RegisterCount>(_outNonMaterializedIndVars.second.size());
TRI_ASSERT(0 == numIndVarsRegisters || isLateMaterialized());
Expand Down Expand Up @@ -536,6 +535,7 @@ std::vector<Variable const*> IndexNode::getVariablesSetHere() const {
_outNonMaterializedIndVars.second.cend(),
std::back_inserter(vars),
[](auto const& indVar) { return indVar.first; });

return vars;
}

Expand Down
4 changes: 0 additions & 4 deletions arangod/IResearch/IResearchDataStore.h
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ class IResearchDataStore {
return _snapshot->_reader;
}

[[nodiscard]] auto const& getSnapshot() const noexcept {
return _snapshot->_snapshot;
}

private:
// lock preventing data store deallocation
LinkLock _lock;
Expand Down
0