8000 [GORDO-1518] Fix memory leak in tests by markuspf · Pull Request #18127 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[GORDO-1518] Fix memory leak in tests #18127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2023
Merged

[GORDO-1518] Fix memory leak in tests #18127

merged 2 commits into from
Feb 20, 2023

Conversation

markuspf
Copy link
Contributor

Scope & Purpose

ASAN/UBSAN detected a load of memory leaks, all caused by not shutting down the runtimes for actors.

This patch fixes the immediate problem; We will look at better solutions for shutting down runtimes gracefully.

To verify this locally I used the following commands

# cmake --preset community-developer-asan-ubsan
# cmake --build --preset community-developer-asan-ubsan --target arangodbtests_actor
# build-presets/bin/arangodbtests_actor

@markuspf markuspf added the 3 Pregel Graph processing label Feb 16, 2023
@markuspf markuspf requested review from jvolmer and MBkkt February 16, 2023 11:55
@cla-bot cla-bot bot added the cla-signed label Feb 16, 2023
@markuspf markuspf changed the title [GORDO-1510] Fix memory leak in tests [GORDO-1518] Fix memory leak in tests Feb 16, 2023
@markuspf markuspf force-pushed the bug-fix/gordo-1510-fix-asan-failure branch from de2e5fe to 949490c Compare February 17, 2023 10:09
hkernbach
hkernbach approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member
@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markuspf markuspf merged commit 7f4d045 into devel Feb 20, 2023
@markuspf markuspf deleted the bug-fix/gordo-1510-fix-asan-failure branch February 20, 2023 11:38
maierlars pushed a commit that referenced this pull request Feb 20, 2023
@apetenchea @Dronplane
@KVS85 @markuspf
[CINFRA] Merging devel (#18152)
bb52831 
* SEARCH-279 snapshot for inverted index (#18128)

* make inverted index read docs from custom snapshot

* wip - adding late materialization snapshot

* wip

* wip

* switch inverted index to viewsnapshot

* fix

* wip

* wip

* try to fix mac build

* fix tests build

* add explicit instantiations

* add test

* fix issue

* add js tests

* clang-format

* cleanup

* adress review comments

* fix for cluster

* review comments

* jslint

* cleanup

* Update OpenSSL to 1.1.1t and OpenLDAP to 2.6.4 (#18148)

* Update ArangoDB Starter to 0.15.7

* [GORDO-1518] Fix memory leak in tests (#18127)

* Free memory held by unique_ptr

* Shutdown runtimes after tests; fixes memory leak

---------

Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Markus Pfeiffer <markuspf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkernbach hkernbach hkernbach approved these changes

@jvolmer jvolmer Awaiting requested review from jvolmer

@MBkkt MBkkt Awaiting requested review from MBkkt

Assignees
No one assigned
Labels
3 Pregel Graph processing cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuspf @hkernbach
0