[PREG-207] Use struct for pregel options #17925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a struct for the pregel options instead of handling everything with a velocypack.
Extracting the pregel parameters (e.g. "store", "shartKeyAttribute", ...) is a bit more work because it involves using structs in all algorithms for their algorithm-specific parameters instead of plain velocypack, therefore this will be done later in another PR.
Additionally, I moved the code that processes the options from the REST handler into the feature, such that the REST handler is doing no business work and processing the options is done at one place: The feature.