8000 APM-84 | Add `spillOverThreshold*` options to Cursor API DocuBlock by Simran-B · Pull Request #17700 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

APM-84 | Add spillOverThreshold* options to Cursor API DocuBlock #17700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 9, 2023
Merged

APM-84 | Add spillOverThreshold* options to Cursor API DocuBlock #17700

merged 7 commits into from
Jan 9, 2023

Conversation

Simran-B
Copy link
Contributor
@Simran-B Simran-B commented Nov 30, 2022 •
edited
Loading

Adds missing AQL query options

Also fixed maxNumberOfPlans (was incorrectly documented as maxPlans).
Tested with curl -d '{"query":"FOR d2 IN c2 FOR d3 IN c3 FOR d1 IN c1 RETURN 1","options":{"maxNumberOfPlans":1,"profile":2}}' http://localhost:8529/_api/cursor | jq '.extra.plan.nodes[] | select(.type == "IndexNode") | .collection' (original order c2-c3-c1 with a single plan, optimal plan re-orders to c1-c2-c3, maxPlans has no such effect).

@Simran-B Simran-B requested a review from a team as a code 8000 owner November 30, 2022 12:30
@cla-bot cla-bot bot added the cla-signed label Nov 30, 2022
@Simran-B Simran-B requested a review from cpjulia November 30, 2022 12:30
@Simran-B Simran-B self-assigned this Nov 30, 2022
@Simran-B Simran-B added this to the 3.11 milestone Nov 30, 2022
This was referenced Nov 30, 2022
Merged
Merged
Simran-B
Simran-B commented Dec 2, 2022
View reviewed changes
cpjulia
cpjulia approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor
@cpjulia cpjulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 65826a5 into devel Jan 9, 2023
@KVS85 KVS85 deleted the documentation/spillover-cursor-api branch January 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpjulia cpjulia cpjulia approved these changes

@nerpaula nerpaula nerpaula approved these changes

Assignees

@Simran-B Simran-B

Labels
3 Documentation cla-signed
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.
4 participants
@Simran-B @cpjulia @nerpaula @KVS85
0