fix traffic accounting in internal statistics / metrics #17654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2022
MBkkt
approved these changes
Nov 24, 2022
…ix-traffic-accounting
|
Jenkins run (not automatically picked up): https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/25935/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #17651
Fix traffic accounting for HTTP/VST in internal statistics / metrics.
Outgoing VST traffic was not accounted for previously.
Additionally, the traffic was not accounted for the request that initiates a protocol change from HTTP/1.1 to HTTP/2.
Finally, the metrics histograms that summed up traffic were not correctly reporting values since 3.10.
For consistency, this PR also adds a new metrics
arangodb_http1_connections_total, which counts the number of HTTP/1.1 connections. There were previously only metrics for HTTP/2 and VST connections.Checklist
Related Information