8000 Delay MoveShard job until old and new leader ready - BTS-1110 by neunhoef · Pull Request #17554 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Delay MoveShard job until old and new leader ready - BTS-1110 #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 14, 2022
Merged

Delay MoveShard job until old and new leader ready - BTS-1110 #17554

merged 9 commits into from
Nov 14, 2022

Conversation

neunhoef
Copy link
Member
@neunhoef neunhoef commented Nov 10, 2022 •
edited
Loading

This addresses https://arangodb.atlassian.net/browse/BTS-1110 .
The problem is that if a MoveShard which switches leadership begins to
work, although the supposed leader has not yet assumed its leadership,
then we get stuck. The old leader does no longer assume leadership and
as a consequence cannot resign and the MoveShard job is stuck.

  • Delay start of MoveShard if supposed leader not in Current.
  • Delay start of MoveShard if new leader not in sync.
  • CHANGELOG.

Scope & Purpose

(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)

  • [*] 💩 Bugfix

Checklist

Related Information

(Please reference tickets / specification / other PRs etc)

@neunhoef neunhoef requested a review from a team as a code owner November 10, 2022 08:56
@neunhoef neunhoef added this to the devel milestone Nov 10, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 10, 2022
@neunhoef neunhoef self-assigned this Nov 10, 2022
maierlars
maierlars approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor
@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code logic is fine. But MoveShard::start() now finally broke the 300 lines mark. Is it possible to put the new code into a separate function?

kvahed
kvahed approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor
@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language

@neunhoef neunhoef changed the title Delay MoveShard job until old and new leader ready Delay MoveShard job until old and new leader ready - BTS-1110 Nov 11, 2022
This was referenced Nov 11, 2022
Merged
Merged
Merged
@neunhoef neunhoef merged commit 0a97c82 into devel Nov 14, 2022
@neunhoef neunhoef deleted the bug-fix/delay-move-shard branch November 14, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

@maierlars maierlars maierlars approved these changes

Assignees

@neunhoef neunhoef

Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@neunhoef @kvahed @maierlars
0