-
Notifications
You must be signed in to change notification settings - Fork 853
setUpAll/tearDownAll for performance reasons #17322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteemann
suggested changes
Oct 11, 2022
jsteemann
reviewed
Oct 12, 2022
jsteemann
reviewed
Oct 12, 2022
jsteemann
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dothebart
added a commit
that referenced
this pull request
Oct 21, 2022
dothebart
added a commit
that referenced
this pull request
Oct 21, 2022
This was referenced Oct 24, 2022
dothebart
added a commit
that referenced
this pull request
Oct 25, 2022
dothebart
added a commit
that referenced
this pull request
Oct 25, 2022
dothebart
added a commit
that referenced
this pull request
Oct 25, 2022
KVS85
pushed a commit
that referenced
this pull request
Oct 31, 2022
KVS85
added a commit
that referenced
this pull request
Nov 2, 2022
* BTS-1077: bulk test data creation (#17329) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * setUpAll/tearDownAll for performance reasons (#17322) * bulk test, don't use graph module (#17319) Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Vadim Kondratyev <vadim@arangodb.com>
KVS85
pushed a commit
that referenced
this pull request
Nov 4, 2022
* BTS-1077: bulk test data creation (#17329) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * setUpAll/tearDownAll for performance reasons (#17322) * bulk test, don't use graph module (#17319) * one more place missing bulk insert (#17189) * use setupAll, split writing tests (#17038) Co-authored-by: Jan <jsteemann@users.noreply.github.com>
KVS85
added a commit
that referenced
this pull request
Nov 7, 2022
* BTS-1077: bulk test data creation (#17329) Co-authored-by: Jan <jsteemann@users.noreply.github.com> * setUpAll/tearDownAll for performance reasons (#17322) * bulk test, don't use graph module (#17319) * one more place missing bulk insert (#17189) * use setupAll, split writing tests (#17038) Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Vadim Kondratyev <vadim@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already hav
60FB
e an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
tests seem to get to slow during the coverage tests.