8000 Fix ARANGODB_RPM_UPSTREAM generation for devel and nightly by KVS85 · Pull Request #16339 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix ARANGODB_RPM_UPSTREAM generation for devel and nightly #16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

Fix ARANGODB_RPM_UPSTREAM generation for devel and nightly #16339

merged 1 commit into from
May 30, 2022

Conversation

KVS85
Copy link
Contributor
@KVS85 KVS85 commented May 26, 2022 •
edited
Loading

Scope & Purpose

We set nightly and devel versions like this (case for nightly) for RPM:

-- ARANGODB PLAIN VERSION: 3.8.7
-- ARANGODB VERSION: 3.8.7-nightly.20220526
-- ARANGODB JS VERSION: js
-- DEBIAN VERSION: 3.8.7 / 1
-- RPM VERSION:    3.8.0 / 0.2.nightly
-- DARWIN VERSION: 3.8.7 / nightly
-- WINDOWS VERSION: 3.8.7-nightly.20220526

In case of alpha, beta, rc, preview or a patch and hotfix releases they are set(ARANGODB_RPM_UPSTREAM "${ARANGODB_PLAIN_VERSION}") which is set(ARANGODB_PLAIN_VERSION "${ARANGODB_VERSION_MAJOR}.${ARANGODB_VERSION_MINOR}.${ARANGODB_VERSION_PATCH}").

That will be the same for RPM with this PR.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@KVS85 KVS85 added 3 Build compiling on targets 3 Packaging Distribution / Packages / Installation labels May 26, 2022
@KVS85 KVS85 added this to the devel milestone May 26, 2022
@KVS85 KVS85 requested a review from fceller May 26, 2022 11:50
@KVS85 KVS85 self-assigned this May 26, 2022
@KVS85 KVS85 added the 4 Linux label May 26, 2022
@KVS85
Copy link
Contributor Author
KVS85 commented May 26, 2022 •
edited
Loading

@KVS85 KVS85 merged commit b04c9ba into devel May 30, 2022
@KVS85 KVS85 deleted the bug-fix/fix-rpm-uprstream-version branch May 30, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fceller fceller fceller approved these changes

Assignees

@KVS85 KVS85

Labels
3 Build compiling on targets 3 Packaging Distribution / Packages / Installation 4 Linux
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@KVS85 @fceller
0