Remove mocha, chalk #15739
Merged
Remove mocha, chalk #15739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothebart
approved these changes
Feb 15, 2022
|
Build failure is unrelated. Restarted jenkins. |
|
jenkins is green |
|
Rerunning jenkins after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
40F1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR removes mocha and chalk. These are internal (undocumented) dependencies that cause unnecessary noise during audits and are no longer used as of 3.8 (see #14501, #14505).
Checklist
Related Information