Feature/single server smart graph #14821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…db/arangodb into feature/single-server-smart-graph � Conflicts: � arangod/Graph/GraphManager.cpp
…db/arangodb into feature/single-server-smart-graph
… satellite graphs (broken).
…db/arangodb into feature/single-server-smart-graph
…db/arangodb into feature/single-server-smart-graph
…gle-server-smart-graph
…db/arangodb into feature/single-server-smart-graph
…db/arangodb into feature/single-server-smart-graph
from Collections::create, extracted validation and building a builder
mchacki
requested changes
Nov 11, 2021
arangod/Sharding/ShardingInfo.cpp
Outdated
| (!_distributeShardsLike.empty() && ServerState::instance()->isSingleServer() && isSmartOrSatellite)) { | ||
| // We either want to expose _distributeShardsLike if we're either on a Coordinator | ||
| // Or we have found a Smart or Satellite collection on a single server instance. | ||
| if (translateCids && !ServerState::instance()->isSingleServer()) { |
There was a problem hiding this comment.
Agree that should not be done on single server.
But the case the cluster enters this code path, will exist on the SingleServer as well.
Is the else path on SingleServer enough to handle this case?
js/apps/system/_admin/aardvark/APP/frontend/js/views/graphManagementView.js
Show resolved
Hide resolved
Co-authored-by: Michael Hackstein <michael@arangodb.com>
Co-authored-by: Michael Hackstein <michael@arangodb.com>
…ollection to allowEnterpriseCollectionsOnSingleServer
…db/arangodb into feature/single-server-smart-graph
|
NOTE for myself. Current State is green.
|
mchacki
approved these changes
Nov 17, 2021
| if (followingTermId == 0) { | ||
| reqOpts.param(StaticStrings::IsSynchronousReplicationString, | ||
| ServerState::instance()->getId()); | ||
| } else {reqOpts.param(StaticStrings::IsSynchronousReplicationString, |
| if (followingTermId == 0) { | ||
| reqOpts.param(StaticStrings::IsSynchronousReplicationString, | ||
| ServerState::instance()->getId()); | ||
| } else {reqOpts.param(StaticStrings::IsSynchronousReplicationString, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied whi
2C40
le the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
SingleServer SmartGraph Simulator
Description can be found here: https://github.com/arangodb/enterprise/pull/765
Backports:
Related Information
IMPORTANT
IMPORTANT