-
Notifications
You must be signed in to change notification settings - Fork 852
APM-164: Add basic overload control to arangod. #14796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6f02ef5
Add basic overload control to arangod.
jsteemann 8540a88
make dequeue time decrease smoother
jsteemann f29c93a
Merge branch 'devel' of github.com:arangodb/arangodb into feature/APM…
jsteemann 6d37569
fix test
jsteemann d29aaec
Update CHANGELOG
kvahed 65cac54
Update arangod/GeneralServer/CommTask.cpp
jsteemann 398a40a
Update arangod/GeneralServer/CommTask.cpp
jsteemann 02fe39d
Update tests/js/client/server_parameters/test-return-queue-time-heade…
jsteemann a83853c
Update tests/js/client/server_parameters/test-return-queue-time-heade…
jsteemann 9bb8a5a
Merge branch 'devel' into feature/APM-164
jsteemann a6caf93
Update tests/js/client/server_parameters/test-return-queue-time-heade…
jsteemann 133a524
Update tests/js/client/server_parameters/test-return-queue-time-heade…
jsteemann f05726b
address comments
jsteemann 1d373e9
Merge branch 'devel' into feature/APM-164
jsteemann 44a4444
Merge branch 'devel' into feature/APM-164
jsteemann fdf8560
Merge branch 'devel' into feature/APM-164
jsteemann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
Documentation/Metrics/arangodb_scheduler_queue_time_violations_total.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: arangodb_scheduler_queue_time_violations_total | ||
introducedIn: "3.9.0" | ||
help: | | ||
Number of tasks/requests dropped and not added to internal queue | ||
due to the client-specified queue time requirements not being | ||
satisfiable. | ||
unit: number | ||
type: counter | ||
category: Scheduler | ||
complexity: simple | ||
exposedBy: | ||
- coordinator | ||
- dbserver | ||
- agent | ||
- single | ||
description: | | ||
Number of tasks/requests dropped because the client-specified queue time | ||
requirements, as indicated by client applications in the request header | ||
"x-arango-queue-time-seconds" could not be satisfied by the receiving | ||
server instance. This happens when the actual time need to queue/dequeue | ||
requests on the scheduler queue exceeds the maximum time value that the | ||
client has specified in the request. | ||
Whenever this happens, the client application will get an HTTP 412 error | ||
response back with error code 21004 ("queue time violated"). | ||
Although the metric is exposed on all instance types, it will very likely | ||
always be 0 on DB servers, simply because coordinators do not forward the | ||
"x-arango-queue-time-seconds" when they send internal requests to DB | ||
servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the outcome if queueTimeValue is not a valid double? If I understand it will just get ignored, would it make sense signal/inform here (e.g., at least on higher log-levels)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, this is set by ArangoDB and not user specified