8000 fix logId check by jsteemann · Pull Request #14794 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

fix logId check #14794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2021
Merged

fix logId check #14794

merged 1 commit into from
Sep 20, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #14793

Fix check script for log ids

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann jsteemann added this to the 3.8 milestone Sep 17, 2021
@jsteemann jsteemann requested a review from kvahed September 17, 2021 09:34
@jsteemann jsteemann mentioned this pull request Sep 17, 2021
Merged
8 tasks
kvahed
kvahed approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor
@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 7cd7389 into 3.8 Sep 20, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/fix-logid-check branch September 20, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

Assignees

@jsteemann jsteemann

Labels
3 - Testing 9 Ready to Merge
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @kvahed @KVS85
0