8000 Avoid acquisition of recursive read lock on server shutdown by jsteemann · Pull Request #14791 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Avoid acquisition of recursive read lock on server shutdown #14791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2021
Merged

Avoid acquisition of recursive read lock on server shutdown #14791

merged 1 commit into from
Sep 20, 2021

Conversation

jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Sep 16, 2021 •
edited
Loading

Scope & Purpose

Enterprise companion PR: https://github.com/arangodb/enterprise/pull/760

  • Avoid the acquisition of a recursive read lock on server shutdown, which
    could in theory lead to shutdown hangs at least if a concurrent thread is
    trying to modify the list of collections (very unlikely and never observed
    until now).
  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Related Information

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann
Avoid acquisition of recursive read lock on server shutdown
75055ac 
* Avoid the acquisition of a recursive read lock on server shutdown, which
  could in theory lead to shutdown hangs at least if a concurrent thread is
  trying to modify the list of collections (very unlikely and never observe
8000
d
  until now).
@jsteemann jsteemann added this to the 3.8 milestone Sep 16, 2021
@jsteemann jsteemann requested a review from mpoeter September 16, 2021 22:46
@jsteemann jsteemann mentioned this pull request Sep 16, 2021
Merged
9 tasks
@KVS85 KVS85 merged commit 1196999 into 3.8 Sep 20, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/fix-unsafe-recursive-lock-on-shutdown branch September 20, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoeter mpoeter mpoeter approved these changes

Assignees

@jsteemann jsteemann

Labels
9 Ready to Merge
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @mpoeter @KVS85
0