comments

arangodb · gnusi · Sep 10, 2021 · Sep 3, 2021 · Sep 6, 2021 · Sep 6, 2021
commit 37be60d0470a45ebe2180b3b4aad28d0793e4c8a
diff --git a/arangod/Aql/IResearchViewNode.h b/arangod/Aql/IResearchViewNode.h
@@ -154,6 +154,8 @@ class IResearchViewNode final : public arangodb::aql::ExecutionNode {
   /// @brief return the scorers to pass to the view
   std::vector<Scorer> const& scorers() const noexcept { return _scorers; }
 
+  // we could merge if it is allowed in general and there are no scores - as changing
+  // filters will affect score and we will lose backward compatibility
   bool allowFiltersMerge() const noexcept { return _options.allowFiltersMerge && _scorers.empty(); }
 
   /// @brief set the scorers to pass to the view

diff --git a/arangod/Aql/IResearchViewOptimizerRules.cpp b/arangod/Aql/IResearchViewOptimizerRules.cpp
@@ -180,8 +180,6 @@ bool optimizeSearchCondition(IResearchViewNode& viewNode, arangodb::aql::QueryCo
   if (searchCondition.root()) {
     if (viewNode.allowFiltersMerge()) {
       // we could benefit from merging STARTS_WITH and LEVENSHTEIN_MATCH
-      // if there is no scorers (with scorers we can't as it will affect score values)
-      // to do so we need to have all levenshtein filters present before first starts_with
       pushStartsWithToBack(*searchCondition.root());
     }
     auto filterCreated = FilterFactory::filter(