8000 attempt to first uninstall the old service on silent upgrade as well by dothebart · Pull Request #14731 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

attempt to first uninstall the old service on silent upgrade as well #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 30, 2021
Merged

attempt to first uninstall the old service on silent upgrade as well #14731

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9ab9e42
attempt to first uninstall the old service on silent upgrade as well,…
dothebart Sep 3, 2021
853d95c
fix syntax
dothebart Sep 3, 2021
87bec32
Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/fix…
dothebart Sep 21, 2021
678b7c2
Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/fix…
dothebart Sep 27, 2021
bee977f
fix non-ui hooks
dothebart Sep 27, 2021
2b0ff77
fix silent upgrade process
dothebart Sep 29, 2021
e0586c9
fix syntax
dothebart Sep 29, 2021
0286100
skip expected error sitiuation from user interaction
dothebart Sep 29, 2021
80b8db8
forward package vendor
dothebart Sep 29, 2021
8240584
fix installed icon path
dothebart Sep 29, 2021
9e1919f
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
KVS85 Sep 30, 2021
c0e676d
Update CHANGELOG
KVS85 Sep 30, 2021
7e1957b
Update CHANGELOG
KVS85 Sep 30, 2021
0bf3f22
Update CHANGELOG
KVS85 Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix non-ui hooks
  • Loading branch information
@dothebart
dothebart committed Sep 27, 2021
commit bee977f7df735d8df75c54d0c4416b88a9f6791e
11 changes: 9 additions & 2 deletions Installation/Windows/Templates/NSIS.template.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ Function check_previous_install
StrCpy $UpgradeInstall "0"
IfFileExists "$DATADIR\@INC_CPACK_ARANGO_DATA_DIR@\SERVER" OldFound
IfFileExists "$DATADIR\@INC_CPACK_ARANGO_DATA_DIR@\ENGINE" OldFound
${if} $IS_DEFAULT_INSTALLDIR == "0"
IfFileExists "$DATADIR\ENGINE" OldFound
${EndIf}
DetailPrint "This is a fresh install."
return
OldFound:
Expand Down Expand Up @@ -650,8 +653,6 @@ FunctionEnd

Function InstallOptionsPage2
IfSilent 0 continueUI
; this would be called inside the UI code:
Call stop_old_service
Return
continueUI:

Expand Down Expand Up @@ -888,6 +889,12 @@ FunctionEnd
;Installer Sections

Section "-Core installation"
IfSilent 0 continueBaseInstall
${If} $UpgradeInstall == "1"
; this would be called inside the UI code:
Call stop_old_service
${EndIf}
continueBaseInstall:
;Use the entire tree produced by the INSTALL target. Keep the
;list of directories here in sync with the RMDir commands below.
SetOutPath "$INSTDIR"
Expand Down
0