[R2] CommitLag Metric + Follower State #14725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 3, 2021 17:17
…ature/replication-2.0-commit-lag-follower-state
goedderz
approved these changes
Sep 8, 2021
added 4 commits
September 8, 2021 11:18
…0-commit-lag-follower-state
…2.0-commit-lag-follower-state
… feature/replication-2.0-commit-lag-follower-state
mpoeter
reviewed
Sep 8, 2021
Comment on lines
448
to
449
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| }); | |
| } | |
| }); |
| }; | ||
| struct FollowerStatistics : LogStatistics { | ||
| AppendEntriesErrorReason lastErrorReason; | ||
| double lastRequestLatencyMS; |
Contributor
There was a problem hiding this comment.
How about we make this a std::chrono::duration<double, std::milli>?
|
|
||
| struct UpToDate {}; | ||
| struct ErrorBackoff { | ||
| double durationMS; |
Contributor
There was a problem hiding this comment.
How about we make this a std::chrono::duration<double, std::milli>?
| std::size_t retryCount; | ||
| }; | ||
| struct RequestInFlight { | ||
| double durationMS; |
Contributor
There was a problem hiding this comment.
How about we make this a std::chrono::duration<double, std::milli>?
| LogTerm term; | ||
| std::unordered_map<ParticipantId, FollowerStatistics> follower; | ||
| // now() - insertTP of last uncommitted entry | ||
| double commitLagMS; |
Contributor
There was a problem hiding this comment.
How about we make this a std::chrono::duration<double, std::milli>?
mpoeter
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Add two new metrics to the log status:
up-to-date,error-backoff(including retryCount and time until retry),request-in-flight(including time passed since request was sent)