8000 Bug fix/search 238 late materialization with constrained heap by Dronplane · Pull Request #14722 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix/search 238 late materialization with constrained heap #14722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Bug fix/search 238 late materialization with constrained heap #14722

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
35889b3
add test for view case
Dronplane Aug 30, 2021
d35e59b
find a better place for sort
Dronplane Sep 1, 2021
90f4223
Merge branch 'devel' into bug-fix/SEARCH-238-Late-materialization-wit…
Dronplane Sep 1, 2021
d151d3d
fix formatting
Dronplane Sep 1, 2021
adfe931
add index case test
Dronplane Sep 1, 2021
16e1fa8
moar tests
Dronplane Sep 1, 2021
28a3e90
temporary relaxed assertion
Dronplane Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix formatting
  • Loading branch information
@Dronplane
Dronplane committed Sep 1, 2021
commit d151d3df67e6c598ebe3b0cf0db92bb01c0f8e8b
10 changes: 5 additions & 5 deletions tests/js/server/aql/aql-optimizer-rule-late-document-materialization-arangosearch.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,11 @@
});
assertEqual(0, expected.size);
},
testConstrainedSortOnDbServer() {
let query = "FOR d IN " + vn + " SEARCH d.value > 9 SORT BM25(d) LIMIT 10 RETURN {key: d._key, value: d.value}";
let plan = AQL_EXPLAIN(query).plan;
testConstrainedSortOnDbServer() {
let query = "FOR d IN " + vn + " SEARCH d.value > 9 SORT BM25(d) LIMIT 10 RETURN {key: d._key, value: d.value}";
let plan = AQL_EXPLAIN(query).plan;
assertNotEqual(-1, plan.rules.indexOf(ruleName));
let materializeNodeFound = false;
let materializeNodeFound = false;
let nodeDependency = null;
plan.nodes.forEach(function(node) {
if( node.type === "MaterializeNode") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe check the whole plan?

Expand All @@ -403,7 +403,7 @@
expected.delete(doc.key);
});
assertEqual(0, expected.size);
}
}
};
};
}());
Expand Down
0