8000 [3.7] move shards with no time limit instead cancellation by kvahed · Pull Request #14719 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[3.7] move shards with no time limit instead cancellation #14719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 11, 2021
Merged

[3.7] move shards with no time limit instead cancellation #14719

merged 22 commits into from
Sep 11, 2021

Conversation

@kvahed
Copy link
Contributor
@kvahed kvahed commented Aug 31, 2021 •
edited
Loading

Scope & Purpose

Fix moveshards timing out prematurely

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: (Please specify versions and link PRs)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR: ES-941
  • GitHub issue / Jira ticket number:
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:
https://jenkins.arangodb.biz/job/arangodb-matrix-pr/16920/

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@kvahed kvahed added this to the 3.7.15 milestone Aug 31, 2021
@kvahed kvahed self-assigned this Aug 31, 2021
@kvahed kvahed marked this pull request as draft August 31, 2021 11:36
neunhoef
neunhoef requested changes Sep 1, 2021
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks like the right approach. See 3 smaller wishes.

neunhoef
neunhoef reviewed Sep 6, 2021
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intermediate commit.

@kvahed kvahed mentioned this pull request Sep 8, 2021
Merged
25 tasks
maierlars
maierlars suggested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor
@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in MoveShards looks good. RestAdminClusterHandler needs more love.

neunhoef
neunhoef approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvahed kvahed marked this pull request as ready for review September 10, 2021 19:53
@KVS85 KVS85 merged commit 4a09aa3 into 3.7 Sep 11, 2021
@KVS85 KVS85 deleted the bug-fix-3.7/allow-for-long-supervision-job-runtimes branch September 11, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neunhoef neunhoef neunhoef approved these changes

+1 more reviewer

@maierlars maierlars maierlars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kvahed kvahed

Labels

3 Cluster 9 Ready to Merge

Projects

None yet

Milestone

3.7.15

Development

Successfully merging this pull request may close these issues.

5 participants

@kvahed @neunhoef @maierlars @KVS85
0