8000 noexcept requirement ScopeGuard by maierlars · Pull Request #14713 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

noexcept requirement ScopeGuard #14713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 3, 2021
Merged

noexcept requirement ScopeGuard #14713

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2e2c4b8
First part of noexcept for scopeGuard.
Aug 30, 2021
328b37c
Fixing arangodbtests as well.
Aug 30, 2021
4500aa5
Added noexcept in support utilities.
Aug 31, 2021
de61b57
Fix UserManagerClusterTest.cpp-
Aug 31, 2021
373ae6f
More noexcept.
Aug 31, 2021
fcf14de
Remove TRI_DEFER.
Aug 31, 2021
5e82ac5
Merge remote-tracking branch 'origin/devel' into feature/noexcept-sco…
Aug 31, 2021
58dbc5b
Fixing merge conflicts.
Aug 31, 2021
81e22bb
Fixing windows.
Aug 31, 2021
2d9f7cf
Fix windows build
mpoeter Sep 1, 2021
2226cc6
Addressed PR comments.
Sep 2, 2021
821243e
Fixing HeartBeat scope guard.
Sep 3, 2021
ac65eee
Added more logging in case of noexcept scope guards.
Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing windows.
  • Loading branch information
maierlars committed Aug 31, 2021
commit 81e22bb01c9185cb38656ca6168a86870757f83f
4 changes: 2 additions & 2 deletions lib/Basics/Mutex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ bool Mutex::try_lock() noexcept { return TryAcquireSRWLockExclusive(&_mutex) !=
void Mutex::unlock() noexcept { ReleaseSRWLockExclusive(&_mutex); }

#ifdef ARANGODB_ENABLE_DEADLOCK_DETECTION
void Mutex::assertLockedByCurrentThread() noexcept {}
void Mutex::assertNotLockedByCurrentThread() noexcept {}
void Mutex::assertLockedByCurrentThread() const noexcept {}
void Mutex::assertNotLockedByCurrentThread() const noexcept {}
#endif

#endif
0