10000 Fix a rare shutdown race in RocksDBShaCalculatorThread by jsteemann · Pull Request #14709 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Fix a rare shutdown race in RocksDBShaCalculatorThread #14709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 3, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added assertion as suggested
  • Loading branch information
jsteemann committed Aug 30, 2021
commit a48ea0570978480028211834f6526a73889b86d3
3 changes: 3 additions & 0 deletions arangod/RocksDBEngine/Listeners/RocksDBShaCalculator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,9 @@ RocksDBShaCalculator::RocksDBShaCalculator(application_features::ApplicationServ

/// @brief Shutdown the background thread only if it was ever started
RocksDBShaCalculator::~RocksDBShaCalculator() {
// when we get here the background thread should have been stopped
// already.
TRI_ASSERT(!_shaThread.isRunning());
waitForShutdown();
}

Expand Down
0