8000 Feature/remove shared ptrs from analyzers by Dronplane · Pull Request #14694 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content
8000

Feature/remove shared ptrs from analyzers #14694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 25, 2021
Merged

Feature/remove shared ptrs from analyzers #14694

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
afbe1d2
update iresearch
Dronplane Aug 25, 2021
f01b1ed
get rid of shared ptrs
Dronplane Aug 25, 2021
2badbfb
guidelines fix
Dronplane Aug 25, 2021
d03b2da
fix build
Dronplane Aug 25, 2021
df8573a
fix build
Dronplane Aug 25, 2021
a683a24
moar uniques
Dronplane Aug 25, 2021
8700558
fix text cmake
Dronplane Aug 25, 2021
2a0c650
fix build
Dronplane Aug 25, 2021
696bc00
fix build
Dronplane Aug 25, 2021
03d40e9
fix storreFunc execution
Dronplane Aug 25, 2021
aa60fce
fix sharing typed analyzer
Dronplane Aug 25, 2021
4b1f347
fix tests
Dronplane Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build
  • Loading branch information
@Dronplane
Dronplane committed Aug 25, 2021
commit 696bc00d0d06ee17245fe23e172e320b07f17f7f
10 changes: 5 additions & 5 deletions tests/IResearch/IResearchAnalyzerFeature-test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ TEST_F(IResearchAnalyzerFeatureTest, test_emplace_add_static_analyzer) {
ASSERT_NE(pool, nullptr);
EXPECT_EQ(arangodb::iresearch::Features(arangodb::iresearch::FieldFeatures::NORM, irs::IndexFeatures::FREQ), pool->features());
auto analyzer = pool->get();
ASSERT_NE(analyzer, nullptr);
ASSERT_NE(analyzer.get(), nullptr);
feature.unprepare();
}

Expand Down Expand Up @@ -1277,7 +1277,7 @@ TEST_F(IResearchAnalyzerFeatureGetTest, test_get_static_analyzer) {
ASSERT_NE(pool, nullptr);
EXPECT_EQ(arangodb::iresearch::Features(arangodb::iresearch::FieldFeatures::NORM, irs::IndexFeatures::FREQ), pool->features());
auto analyzer = pool->get();
ASSERT_NE(analyzer, nullptr);
ASSERT_NE(analyzer.get(), nullptr);
}

TEST_F(IResearchAnalyzerFeatureGetTest, test_get_static_analyzer_adding_vocbases) {
Expand All @@ -1287,7 +1287,7 @@ TEST_F(IResearchAnalyzerFeatureGetTest, test_get_static_analyzer_adding_vocbases
ASSERT_NE(pool, nullptr);
EXPECT_EQ(arangodb::iresearch::Features(arangodb::iresearch::FieldFeatures::NORM, irs::IndexFeatures::FREQ), pool->features());
auto analyzer = pool->get();
ASSERT_NE(analyzer, nullptr);
ASSERT_NE(analyzer.get(), nullptr);
}

// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -1458,7 +1458,7 @@ TEST_F(IResearchAnalyzerFeatureTest, test_identity_static) {
EXPECT_EQ(arangodb::iresearch::Features(arangodb::iresearch 6FB1 ::FieldFeatures::NORM, irs::IndexFeatures::FREQ), pool->features());
EXPECT_EQ("identity", pool->name());
auto analyzer = pool->get();
ASSERT_NE(nullptr, analyzer);
ASSERT_NE(nullptr, analyzer.get());
auto* term = irs::get<irs::term_attribute>(*analyzer);
ASSERT_NE(nullptr, term);
EXPECT_FALSE(analyzer->next());
Expand All @@ -1480,7 +1480,7 @@ TEST_F(IResearchAnalyzerFeatureTest, test_identity_registered) {
EXPECT_EQ(arangodb::iresearch::Features(arangodb::iresearch::FieldFeatures::NORM, irs::IndexFeatures::FREQ), pool->features());
EXPECT_EQ("identity", pool->name());
auto analyzer = pool->get();
ASSERT_NE(nullptr, analyzer);
ASSERT_NE(nullptr, analyzer.get());
auto* term = irs::get<irs::term_attribute>(*analyzer);
ASSERT_NE(nullptr, term);
EXPECT_FALSE(analyzer->next());
Expand Down
0