10000 fix potential issue during cluster index creation by jsteemann · Pull Request #14690 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

fix potential issue during cluster index creation #14690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2021
Merged

fix potential issue during cluster index creation #14690

merged 2 commits into from
Aug 25, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Fix a potential multi-threading issue in index creation on coordinators, when an agency callback was triggered at the same time the method ensureIndexCoordinatorInner was left.

Found this randomly by checking the results of another Jenkins job:
https://jenkins.arangodb.biz/job/arangodb-matrix-pr-linux/17920/EDITION=community,STORAGE_ENGINE=mmfiles,TEST_SUITE=cluster,limit=linux&&(test%7C%7Cbuild)%7C%7Cgce/artifact/testfailures.txt

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann
fix potential issue during cluster index creation
59ff6ee 
* Fix a potential multi-threading issue in index creation on coordinators,
  when an agency callback was triggered at the same time the method
  `ensureIndexCoordinatorInner` was left.
@jsteemann jsteemann added this to the 3.7 milestone Aug 24, 2021
This was referenced Aug 24, 2021
Merged
Merged
neunhoef
neunhoef approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 5f0e28c into 3.7 Aug 25, 2021
@KVS85 KVS85 deleted the bug-fix-3.7/fix-random-crash-in-collection-watcher branch August 25, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

@maierlars maierlars Awaiting requested review from maierlars

Assignees

@jsteemann jsteemann

Labels
1 Bug 3 Cluster 3 Index
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @neunhoef @KVS85
0