8000 reintroduce --cluster.index-create-timeout for testing by jsteemann · Pull Request #14679 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

reintroduce --cluster.index-create-timeout for testing #14679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2021
Merged

reintroduce --cluster.index-create-timeout for testing #14679

merged 2 commits into from
Aug 24, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #14678

Reintroduce --cluster.index-create-timeout startup option, because we want the timeout to be configurable for arangosync testing. The option was obsoleted and the timeout was set to a hard-coded value in a recent PR. We now make it configurable again so we can set it to very small timeouts for testing.

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • Backports required for: 3.7, 3.6

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann
reintroduce --cluster.index-create-timeout for testing
4f35b2f 
we want the timeout to be configurable for arangosync testing.
@jsteemann jsteemann added this to the 3.8 milestone Aug 24, 2021
@jsteemann jsteemann requested a review from neunhoef August 24, 2021 10:31
@jsteemann jsteemann mentioned this pull request Aug 24, 2021
Merged
8 tasks
neunhoef
neunhoef approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 1924872 into 3.8 Aug 24, 2021
@KVS85 KVS85 deleted the feature-3.8/reintroduce-index-create-timeout branch August 24, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@jsteemann jsteemann

Labels
3 Cluster 3 Index
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @neunhoef @KVS85
0