8000 improvements for memory-mapped files by jsteemann · Pull Request #14657 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

improvements for memory-mapped files #14657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2021
Merged

improvements for memory-mapped files #14657

merged 2 commits into from
Aug 23, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #14636

  • When creating Pregel memory-mapped files, create them with O_TMPFILE attribute on Linux so that files are guaranteed to vanish even if a process dies.
  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Testing & Verification

  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as shell_client, gtest.

@jsteemann jsteemann added this to the 3.7 milestone Aug 17, 2021
@jsteemann jsteemann requested review from kvahed and mpoeter August 17, 2021 23:31
kvahed
kvahed approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor
@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 added the 3 Pregel Graph processing label Aug 23, 2021
@KVS85 KVS85 merged commit 972a53b into 3.7 Aug 23, 2021
@KVS85 KVS85 deleted the bug-fix-3.7/pregel-improvements branch August 23, 2021 20:26
Sign up for free to join this conversation on GitHub. Already 70B3 have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

@mpoeter mpoeter mpoeter approved these changes

Assignees

@jsteemann jsteemann

Labels
3 Pregel Graph processing 9 Ready to Merge
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jsteemann @kvahed @mpoeter @KVS85
0