8000 use more sensible values for timeouts/renewals by jsteemann · Pull Request #14638 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

use more sensible values for timeouts/renewals #14638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2021
Merged

use more sensible values for timeouts/renewals #14638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions js/apps/system/_admin/aardvark/APP/frontend/js/views/footerView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,31 @@
// only try to renew token if we are still online
return;
}

var frac = (frontendConfig.sessionTimeout >= 1800) ? 0.95 : 0.8;
// threshold for renewal: once session is x% over
var renewalThreshold = frontendConfig.sessionTimeout * frac;

var now = Date.now() / 1000;
var lastActivity = arangoHelper.lastActivity();

if (lastActivity > 0 && (now - lastActivity) > 90 * 60) {
// seconds in which the last user activity counts as significant
var lastSignificantActivityTimePeriod = 90 * 60;

// if this is more than the renewal threshold, limit it
if (lastSignificantActivityTimePeriod > renewalThreshold * 0.95) {
lastSignificantActivityTimePeriod = renewalThreshold * 0.95;
}

if (lastActivity > 0 && (now - lastActivity) > lastSignificantActivityTimePeriod) {
// don't make an attempt to renew the token if last
// user activity is longer than 90 minutes ago
return;
}

// to save some superfluous HTTP requests to the server,
// try to renew only if session time is x% or more over
var frac = (frontendConfig.sessionTimeout >= 1800) ? 0.95 : 0.8;
if (now - self.lastTokenRenewal < frontendConfig.sessionTimeout * frac) {
if (now - self.lastTokenRenewal < renewalThreshold) {
return;
}

Expand Down
0