E5E0 Suppress a useless warning by goedderz · Pull Request #14624 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Suppress a useless warning #14624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Suppress a useless warning #14624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d20f9
Suppress a useless warning
goedderz Aug 11, 2021
0443b90
Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/sup…
goedderz Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/Replication2/ConcurrencyTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,24 @@ struct ReplicatedLogConcurrentTest : ReplicatedLogTest {

// Used to generate payloads that are unique across threads.
constexpr static auto genPayload = [](ThreadIdx thread, IterIdx i) {
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wtype-limits"
#endif
// up to 5 digits for thread
static_assert(std::numeric_limits<ThreadIdx>::max() <= 99'999);
// up to 10 digits for i
static_assert(std::numeric_limits<IterIdx>::max() <= 99'999'999'999);
#if defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

// This should fit into short string optimization
auto str = std::string(16, ' ');

auto p = str.begin() + 5;
// up to 5 digits for thread
static_assert(std::numeric_limits<ThreadIdx>::max() <= 99'999);
// 1 digit for ':'
*p = ':';
// up to 10 digits for i
static_assert(std::numeric_limits<IterIdx>::max() <= 99'999'999'999);

do {
--p;
Expand Down
0