E51C [3.8] Fix BTS-527 by kvahed · Pull Request #14537 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[3.8] Fix BTS-527 #14537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2021
Merged

[3.8] Fix BTS-527 #14537

merged 6 commits into from
Jul 28, 2021

Conversation

@kvahed
Copy link
Contributor
@kvahed kvahed commented Jul 22, 2021 •
edited
Loading

Scope & Purpose

Coordinators handle plan changes for databases in wrong order, leading to databases being listed but not useable after some hot restores

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: 3.7

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket number:
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:
https://jenkins.arangodb.biz/job/arangodb-matrix-pr/16328/

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@kvahed kvahed added this to the 3.8.1 milestone Jul 22, 2021
@kvahed kvahed requested a review from maierlars July 22, 2021 10:03
@kvahed kvahed self-assigned this Jul 22, 2021
jsteemann
jsteemann reviewed Jul 22, 2021
View reviewed changes
@kvahed kvahed mentioned this pull request Jul 22, 2021
Merged
25 tasks
jsteemann
jsteemann approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit d113f07 into 3.8 Jul 28, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/wrong-order-on-coordinator-drop-database-and-create-database branch July 28, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jsteemann jsteemann jsteemann approved these changes

@maierlars maierlars maierlars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kvahed kvahed

Labels

1 Bug 3 Cluster Team Clifton

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

5 participants

@kvahed @jsteemann @maierlars @KVS85
0