[3.8] make AQL modification operations async #14525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the AQL modification operations INSERT, UPDATE, REPLACE, REMOVE return futures so they become non-blocking. UPSERT is currently still blocking, but this will be addressed soon. Async operations work for `produceRows` already in single server and cluster mode, but `skipRowsRange` does not yet work in cluster mode. This still needs to be sorted out. After that, UPSERT needs to be made async.
…Modification Blocks
…sync-aql-modification-operations
…fore writing; some refactoring
…sync-aql-modification-operations
Co-authored-by: Michael Hackstein <michael@arangodb.com>
mchacki
approved these changes
Aug 11, 2021
mchacki
approved these changes
Aug 16, 2021
goedderz
added a commit
that referenced
this pull request
Aug 16, 2021
25 tasks
|
As to DO_NOT_MERGE: We most probably found a way to resolve the deadlocks with a much less intrusive patch, which is preferable for 3.8. The changes here are still desirable and already merged to devel, but we might get around without merging them into a stable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not be merged to 3.8, as the much simpler bugfix #14695 (respectively #14699) suffices to resolve deadlocks.
Scope & Purpose
This PR makes the AQL modification operations INSERT, UPDATE, REPLACE, REMOVE return futures so they become non-blocking. UPSERT is currently still blocking, but this will be addressed soon.
UPSERT needs to be made async later.
Backports:
Testing & Verification