8000 Bug fix/UI logs view removed dom element by hkernbach · Pull Request #14520 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix/UI logs view removed dom element #14520

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Bug fix/UI logs view removed dom element #14520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1fe6028
removed console log, added missing closing span, fixed use of wrong r…
hkernbach Jul 19, 2021
64aa9c8
added changelog
hkernbach Jul 19, 2021
6c8c1fa
Update CHANGELOG
KVS85 Jul 28, 2021
be59ad6
Merge branch 'devel' into bug-fix/ui-logs-view-removed-dom-element
KVS85 Aug 5, 2021
22923b6
Rebuild UI
KVS85 Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
removed console log, added missing closing span, fixed use of wrong r… 
…emove method in loggerView
  • Loading branch information
@hkernbach
hkernbach committed Jul 19, 2021
commit 1fe6028b67c0bab9e9c6af29e6c7e59bcc3c2ffc
1 change: 0 additions & 1 deletion js/apps/system/_admin/aardvark/APP/frontend/js/routers/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@

if (this.lastRoute === '#services') {
window.App.replaceApp = false;
// console.log('set replace to false!');
}

if (this.graphViewer) {
Expand Down
4 changes: 2 additions & 2 deletions js/apps/system/_admin/aardvark/APP/frontend/js/templates/modalCollectionInfo.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ if (!figuresData.figures) {
</th>
</tr>
<% } %>

<% if (figuresData.hasOwnProperty('syncByRevision')) { %>
<tr>
<th class="collectionInfoTh2">Uses revision trees:</th>
Expand Down Expand Up @@ -303,7 +303,7 @@ if (!figuresData.figures) {
<span><%= shardName %></span>
</td>
<td>
<span><%= count %>
<span><%= count %></span>
</td>
<td>
<%
Expand Down
8 changes: 8 additions & 0 deletions js/apps/system/_admin/aardvark/APP/frontend/js/views/loggerView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@
}
},

remove: function () {
this.$el.empty().off(); /* off to unbind the events */
this.stopListening();
this.unbind();
delete this.el;
return this;
},

currentLoglevel: undefined,
defaultLoglevel: 'info',

Expand Down
0