8000 Fix invalid assertion and always remove blocker object on replication failure by jsteemann · Pull Request #14498 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix invalid assertion and always remove blocker object on replication failure #14498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 14, 2021
Merged

Fix invalid assertion and always remove blocker object on replication failure #14498

merged 9 commits into from
Jul 14, 2021

Conversation

jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jul 13, 2021 •
edited
Loading

Scope & Purpose

Slightly extend chaos tests and add some fixes that occurred during chaos, in particular:

  • always remove blocker object for revision trees in case of replication failure
  • fix hasBlockerUpTo function
  • fix invalid assertion
  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as chaos.

@jsteemann jsteemann added this to the 3.8 milestone Jul 13, 2021
@jsteemann jsteemann requested review from KVS85 and mpoeter July 13, 2021 23:29
mpoeter
mpoeter approved these changes Jul 14, 2021
View reviewed changes
jsteemann and others added 3 commits July 14, 2021 10:10
@jsteemann @mpoeter
Update arangod/RocksDBEngine/RocksDBMetadata.cpp
c63ae9e 
Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com>
@jsteemann @mpoeter
Update arangod/RocksDBEngine/RocksDBMetaCollection.cpp
9546327 
Co-authored-by: Manuel Pöter <manuel.poeter@leanfive.com>
@jsteemann
apply review suggestion
d1897f8
@jsteemann jsteemann changed the title fixes for chaos tests Fix invalid assertion and always remove blocker object on replication failure Jul 14, 2021
Base automatically changed from feature-3.8/cluster-chaos-load-test to 3.8 July 14, 2021 12:22
KVS85
KVS85 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jsteemann added a commit that referenced this pull request Jul 14, 2021
@jsteemann
forward port of #14498
19651f5
@jsteemann jsteemann mentioned this pull request Jul 14, 2021
Merged
9 tasks
@KVS85 KVS85 merged commit c87039d into 3.8 Jul 14, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/fix-cluster-chaos-load-test branch July 14, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 approved these changes

@mpoeter mpoeter mpoeter approved these changes

Assignees

@jsteemann jsteemann

Labels
1 Bug 3 - Testing 3 Cluster
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @KVS85 @mpoeter
0