8000 improve shell-aql-query-setup-timeout test by jsteemann · Pull Request #14488 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

improve shell-aql-query-setup-timeout test #14488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

improve shell-aql-query-setup-timeout test #14488

merged 1 commit into from
Jul 28, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Improve shell-aql-query-setup-timeout test

  • added a missing fail()
  • allow 2 different errors codes (both are possible)

This PR only makes a change to the test, so there is intentionally no CHANGELOG entry for it.

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann
improve shell-aql-query-setup-timeout test
5756141 
- added a missing `fail()`
- allow 2 different errors codes (both are possible)
@jsteemann jsteemann added this to the 3.8 milestone Jul 8, 2021
@jsteemann jsteemann requested a review from KVS85 July 8, 2021 19:40
@jsteemann jsteemann mentioned this pull request Jul 8, 2021
Merged
8 tasks
KVS85
KVS85 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit 6e1b835 into 3.8 Jul 28, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/improve-test branch July 28, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 approved these changes

@mpoeter mpoeter mpoeter approved these changes

Assignees

@jsteemann jsteemann

Labels
3 - Testing 9 Ready to Merge
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @KVS85 @mpoeter
0