8000 Added (gauge) metric "rocksdb_read_only" by jsteemann · Pull Request #14469 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Added (gauge) metric "rocksdb_read_only" #14469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2021
Merged

Added (gauge) metric "rocksdb_read_only" #14469

merged 2 commits into from
Jul 8, 2021

Conversation

jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jul 5, 2021 •
edited
Loading

Scope & Purpose

Backport of #14470

  • APM-107: Added metric "rocksdb_read_only" to determine whether RocksDB is currently in read-only mode due to a background error. The metric will have a value of "1" if RocksDB is in read-only mode and "0" if RocksDB is in normal operations mode. If the metric value is "1" it means all writes into RocksDB will fail, so inspecting the logfiles and acting on the actual error situation is required.

PR was tested manually by starting arangod using a space-constrained tmpfs directory, and writing data into it until RocksDB went into read-only mode. While doing that, metrics were retrieved periodically so check if the "rocksdb_read_only" metric flipped from "0" to "1".
Also verified manually that it goes back to "0" if RocksDB is able to resume normal operations.

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Related Information

Testing & Verification

  • The behavior in this PR was manually tested

@jsteemann
Added (gauge) metric "rocksdb_read_only"
c15de4a 
* APM-107: Added metric "rocksdb_read_only" to determine whether RocksDB is
  currently in read-only mode due to a background error. The metric will have
  a value of "1" if RocksDB is in read-only mode and "0" if RocksDB is in
  normal operations mode. If the metric value is "1" it means all writes into
  RocksDB will fail, so inspecting the logfiles and acting on the actual error
  situation is required.
@jsteemann jsteemann added this to the 3.7 milestone Jul 5, 2021
This was referenced Jul 5, 2021
Merged
Merged
@KVS85 KVS85 added the 3 Metrics label Jul 8, 2021
@KVS85 KVS85 merged commit e88ab99 into 3.7 Jul 8, 2021
@KVS85 KVS85 deleted the feature-3.7/apm-107 branch July 8, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goedderz goedderz goedderz approved these changes

Assignees

@jsteemann jsteemann

Labels
3 Metrics
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @goedderz @KVS85
0