8000 Search 161 3.7 by alexbakharew · Pull Request #14444 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Search 161 3.7 #14444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 2, 2021
Merged

Search 161 3.7 #14444

merged 6 commits into from
Jul 2, 2021

Conversation

@alexbakharew
Copy link
Contributor
@alexbakharew alexbakharew commented Jul 1, 2021

Scope & Purpose

(Please describe the changes in this PR for reviewers - mandatory)

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: (Please specify versions and link PRs)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket number:
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@alexbakharew alexbakharew changed the base branch from devel to 3.7 July 1, 2021 16:16
@alexbakharew alexbakharew requested a review from gnusi July 1, 2021 16:28
@alexbakharew alexbakharew requested review from KVS85 and gnusi July 1, 2021 16:28
gnusi
gnusi suggested changes Jul 1, 2021
View reviewed changes
CHANGELOG Outdated
* Updated arangosync to 1.6.0.
* Add prefix parameter to LEVENSHTEIN_MATCH function in ArangoSearch

* Removed redirects from /_admin/cluster* to /_admin/cluster/*. Adjusted
Copy link
Contributor
@gnusi gnusi Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely unrelated to this PR

tests/Aql/DecaysFunctionTest.cpp Outdated
namespace {

// helper functions
SmallVector<AqlValue> createArgVec(const VPackSlice slice) {
Copy link
Contributor
@gnusi gnusi Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely unrelated to this PR

tests/IResearch/IResearchFeature-test.cpp Outdated
{ "LEVENSHTEIN_MATCH", { ".,.,.|.,.", FunctionType::FILTER } },
{ "LEVENSHTEIN_MATCH", { ".,.,.|.,.,.", FunctionType::FILTER } },
{ "IN_RANGE", { ".,.,.,.,.", FunctionType::FILTER } },
{ "GEO_IN_RANGE", { ".,.,.,.|.,.,.", FunctionType::FILTER } },
Copy link
Contributor
@gnusi gnusi Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely unrelated to this PR

@KVS85 KVS85 added this to the 3.7 milestone Jul 2, 2021
KVS85
KVS85 reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit 62d9789 into 3.7 Jul 2, 2021
@KVS85 KVS85 deleted the Search-161-3.7 branch July 2, 2021 15:28
@Simran-B Simran-B mentioned this pull request Jul 20, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KVS85 KVS85 KVS85 left review comments

+1 more reviewer

@gnusi gnusi gnusi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexbakharew alexbakharew

Labels

1 Bug 3 ArangoSearch Views

Projects

None yet

Milestone

3.7

Development

Successfully merging this pull request may close these issues.

4 participants

@alexbakharew @gnusi @KVS85
0