8000 Bug fix 3.7/presupp 358 by mchacki · Pull Request #14441 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix 3.7/presupp 358 #14441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Bug fix 3.7/presupp 358 #14441

wants to merge 3 commits into from

Conversation

mchacki
Copy link
Member
@mchacki mchacki commented Jul 1, 2021

Scope & Purpose

Backport of #14404

The weakly-connected-components algorithm in Pregel has a small chance to return incorrect components.
If there is a part of the component only connected via OUTBOUND edges to the part of the component that defines the ID there was a chance that the ID was not transported against the OUTBOUND direction. The backwards communication was not correctly implemented.

e.g.

(6)->(2)->(3)->(4)->(5)->(1)

Should be one Component.
in the original implementation (6) and (2) would false create their own component, as the backwards connection (3) <- (2) was not retained until the compenentID 1 did arrive at (3).

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: (Please specify versions and link PRs)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket number: PRESUPP-358
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@mchacki mchacki added this to the 3.7 milestone Jul 1, 2021
@mchacki mchacki requested a review from maierlars July 1, 2021 09:40
@mchacki mchacki self-assigned this Jul 1, 2021
@KVS85 KVS85 added 3 Pregel Graph processing DO_NOT_MERGE labels Jul 2, 2021
@KVS85 KVS85 marked this pull request as draft August 4, 2021 21:24
@mchacki
Copy link
Member Author
mchacki commented Sep 13, 2021

Needs some other work first, the mechanism has changed internally which is not part of this PR.

@mchacki mchacki closed this Sep 13, 2021
@fceller fceller deleted the bug-fix-3.7/presupp-358 branch August 25, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maierlars maierlars maierlars approved these changes

Assignees

@mchacki mchacki

Labels
3 Pregel Graph processing DO_NOT_MERGE
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@mchacki @maierlars @KVS85
0