8000 Enable -Og for debug builds by goedderz · Pull Request #14438 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Enable -Og for debug builds #14438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Enable -Og for debug builds #14438

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a238fa
Enable -Og for debug builds
goedderz Jul 1, 2021
9626e11
Suppress bogus diagnostics
goedderz Jul 5, 2021
dc48c18
Suppress nonnull diagnostic globally for buggy gcc 11.1.0
goedderz Jul 5, 2021
10c057e
Try to make apple clang happy
goedderz Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress nonnull diagnostic globally for buggy gcc 11.1.0
  • Loading branch information
@goedderz
goedderz committed Jul 5, 2021
commit dc48c1821d2d62508aca206f0656e7d65be6143b
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,9 @@ else () # NOT MSVC
message(STATUS "Compiler type GNU: ${CMAKE_CXX_COMPILER}")
set(BASE_FLAGS "-Wall -Wextra -Wno-unused-parameter -Wno-deprecated-declarations ${BASE_FLAGS}")
set(EXTRA_CXX_FLAGS "-Wsuggest-override -Wnon-virtual-dtor")
if (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL "11.1.0")
set(EXTRA_CXX_FLAGS "${EXTRA_CXX_FLAGS} -Wno-error=nonnull")
endif()
elseif (CMAKE_COMPILER_IS_CLANG)
message(STATUS "Compiler type CLANG: ${CMAKE_CXX_COMPILER}")
set(BASE_FLAGS "-Wall -Wextra -Wno-unused-parameter -Wno-deprecated-declarations ${BASE_FLAGS}")
Expand Down
7 changes: 0 additions & 7 deletions lib/Basics/CrashHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,10 +672,6 @@ void CrashHandler::installCrashHandler() {
SetUnhandledExceptionFilter(unhandledExceptionFilter);
#endif

#if defined(__GNUC__) && (__GNUC__ == 11) && (__GNUC_MINOR__ <= 1)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wnonnull"
#endif
// install handler for std::terminate()
std::set_terminate([]() {
char buffer[256];
Expand Down Expand Up @@ -711,9 +707,6 @@ void CrashHandler::installCrashHandler() {

CrashHandler::crash(&buffer[0]);
});
#if defined(__GNUC__) && (__GNUC__ == 11) && (__GNUC_MINOR__ <= 1)
#pragma GCC diagnostic pop
#endif
}

#ifdef _WIN32
Expand Down
0