8000 Feature/hybrid smart graph testsuite extended by hkernbach · Pull Request #14432 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Feature/hybrid smart graph testsuite extended #14432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 117 commits into from
Jul 6, 2021
Merged

Feature/hybrid smart graph testsuite extended #14432

merged 117 commits into from
Jul 6, 2021

Conversation

hkernbach
Copy link
Member
@hkernbach hkernbach commented Jun 30, 2021 •
edited
Loading

Scope & Purpose

Modified Mocks for more flexibility in our CPP testing environment.
Mostly EE relevant changes, see https://github.com/arangodb/enterprise/pull/699 for more details.

mchacki and others added 30 commits April 21, 2021 11:35
@mchacki
Added Protected default constructor for Valdiators
780a86c
@mchacki
Make createKey constant
b246d14
@mchacki
Prepare to use an internal Validator that is not user-modifyable. Thi…
56bf5ef 
…s is mainly used in Enterprise Code
@mchacki
Make setIntenralValidator a public method so we can actually call it …
579230b 
…at the relevant position
@hkernbach
todo
1a74899
@hkernbach
add satellites to GraphNode v2
4231ca4
@hkernbach
add satellites to shard locking
8958c0b
@hkernbach
typo
594b916
@hkernbach
added comments to some methods
29479d0
@hkernbach
adjusted shard locking
1eec739
@hkernbach
extended getAllLocalShards
663e6a2
@hkernbach
remove not needed methods
f751a6c
@mchacki
Add a place to inject internal Schema validation, used e.g. to valida…
b6390d9 
…te correct smartgraph schema
@mchacki
Merge remote-tracking branch 'origin' into feature/use-validators-on-…
3208a80 
…smart-edge-collections
@mchacki
Disabled enterprise Validator Factory
eaca7ce
@mchacki
Removed ValidatorFactory, we do it in a different way
5113205
@hkernbach
Merge branch 'feature/hybrid-smart-graph' of github.com:arangodb/aran…
b113a36 
…godb into feature/hybrid-smart-graph-testsuite
@hkernbach
Merge branch 'feature/use-validators-on-smart-edge-collections' of gi…
0c90d99 
…thub.com:arangodb/arangodb into feature/hybrid-smart-graph-testsuite
@hkernbach
Merge branch 'feature/hybrid-smart-graph' of github.com:arangodb/aran…
63f4ed2 
…godb into feature/hybrid-smart-graph-testsuite
@hkernbach
Merge branch 'feature/hybrid-smart-graph' of github.com:arangodb/aran…
d869fa2 
…godb into feature/hybrid-smart-graph-testsuite
@mchacki
Added more template instanciations
f97e342
@mchacki
Make collection to shard map a map of string -> vector<string>, requi…
c01bec8 
…red for SmartGraphs
@hkernbach
changed api of getNextPath, not modifying builder but returning PathR…
cb9f78f 
…esult instead - will lead to more flexibility handling the result
@mchacki
First draft of toSchreierEntry for HTTP transport. This is a hacky va…
add77c8 
…riant, we need to modify the result to have it correct
@mchacki
Simplified SingleProviderPathResult and EdgeDocument token.
dce04f4
@hkernbach
typo, adjusted format for first step in schreier format
532ad82
@hkernbach
tmp enable smartSearchNew for testing
0eb70ef
@hkernbach
add start/reset depth parameter, default is 0
877a6a7
@hkernbach
added dfspathfinder path_loop test
220aa99
@hkernbach
added dfspathfinder triangle_loop test
09337ed
mchacki and others added 21 commits June 15, 2021 11:35
@mchacki
Made Expressions use shared_ptr in path validator. We can happily reu…
72b4f93 
…se them from different places as long as we do not do it in multithreaded fashion
@hkernbach
allow to restrict collections
7887420
@hkernbach
Merge branch 'feature/hybrid-smart-graph-testsuite' of github.com:ara…
1eaa27d 
…ngodb/arangodb into feature/hybrid-smart-graph-testsuite
@hkernbach
fixed cpp test compilation
5ee84fc
@hkernbach
added method to shard to check wheter we're responsible
d315a04
@hkernbach
trying to fix se search with lookupTable
83d5d91
@hkernbach
added isResponsible method to mock provider step
6559d38
@hkernbach
implemented schreier path building
bed40c2
@hkernbach
Merge branch 'feature/hybrid-smart-graph' of github.com:arangodb/aran…
e957a22 
…godb into feature/hybrid-smart-graph-testsuite
@mchacki
Fixed looseEndReporting.
96b58aa
@hkernbach
adjusted print method
2c87281
@hkernbach
Merge branch 'feature/hybrid-smart-graph-testsuite' of github.com:ara…
eda7279 
…ngodb/arangodb into feature/hybrid-smart-graph-testsuite
@mchacki
Let enumerator report Filtered Paths
4d6de4d
@hkernbach
removed obsolete comment
c88f5de
@mchacki
Fixed unnecessary document lookup if the server is NOT responsible to…
7fc5a2d 
… check for the data
@mchacki
Do not apply validators on Vertices the server is not responsible for…
817434e 
…, it cannot decide this
@hkernbach
first commit - wip
a70c7d5
@hkernbach
small refactoring to become more modular
da0c73f
@hkernbach
move shards back to private
3d1ce2d
@hkernbach
add two variables to protected
798c32d
@hkernbach
Added merge conflicts
13f4c13
@hkernbach hkernbach requested a review from mchacki June 30, 2021 13:48
mchacki
mchacki approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have a minor suggestion.

@hkernbach @mchacki
Update tests/Mocks/Servers.cpp
6ccc2b4 
Co-authored-by: Michael Hackstein <michael@arangodb.com>
@hkernbach hkernbach marked this pull request as ready for review July 5, 2021 11:41
@mchacki mchacki merged commit 71d3495 into feature/hybrid-smart-graph Jul 6, 2021
@mchacki mchacki deleted the feature/hybrid-smart-graph-testsuite-extended branch July 6, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchacki mchacki mchacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkernbach @mchacki
0