10000 Add Intel Comet Lake to the microarchitecture detection script by naushniki · Pull Request #14414 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Add Intel Comet Lake to the microarchitecture detection script #14414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Add Intel Comet Lake to the microarchitecture detection script #14414

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90dee65
Add Intel Comet Lake to the microarchitecture detection script
Jun 28, 2021
e47db67
retire cpu microarchitectures older than minimal required(sandy-bridge)
Jun 28, 2021
cb5156c
Fail if CPU is older than Sandy Bridge and ASM optimizations are enab…
Jun 28, 2021
d23b242
fix error: actually set march to sandy-bridge
Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fail if CPU is older than Sandy Bridge and ASM optimizations are enab… 
…led.
  • Loading branch information
Vitaly Pryakhin committed Jun 28, 2021
commit cb5156c1f18c6f2cfd895c4e978081d294fbe31b
8 changes: 6 additions & 2 deletions cmake/OptimizeForArchitecture.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,13 @@ macro(AutodetectHostArchitecture)
set(TARGET_ARCHITECTURE "ivy-bridge")
elseif(_cpu_model EQUAL 42 OR _cpu_model EQUAL 45)
set(TARGET_ARCHITECTURE "sandy-bridge")
elseif(_cpu_model GREATER 42)
message(WARNING "Your CPU (family ${_cpu_family}, model ${_cpu_model}) is not known. Auto-detection of optimization flags failed and will use the minimum required microarchitecture(sandy-bridge).")
elseif(NOT ASM_OPTIMIZATIONS)
message(WARNING "Your CPU (family ${_cpu_family}, model ${_cpu_model}) is not known. This is not fatal because ASM_OPTIMIZATIONS are disabled. If you want to use ASM_OPTIMIZATIONS make sure you have a compliant CPU(sandy-bridge or newer) and review the \"cmake/OptimizeForArchitecture.cmake\" script.")
set(TARGET_ARCHITECTURE "generic")
else()
message(WARNING "Your CPU (family ${_cpu_family}, model ${_cpu_model}) is not known. Auto-detection of optimization flags failed and will use the minimum required microarchitecture(sandy-bridge).")
set(TARGET_ARCHITECTURE "sandy-bridge")
message(FATAL_ERROR "Your CPU (family ${_cpu_family}, model ${_cpu_model}) is not known. This is fatal, because ASM_OPTIMIZATIONS are ON. If your CPU microarchitecture is sandy-bridge or newer, please review the \"cmake/OptimizeForArchitecture.cmake\" script. If you have an older CPU, use -DASM_OPTIMIZATIONS=Off.")
endif()
elseif(_cpu_family EQUAL 7) # Itanium (not supported)
message(WARNING "Your CPU (Itanium: family ${_cpu_family}, model ${_cpu_model}) is not supported by OptimizeForArchitecture.cmake.")
Expand Down
0