8000 Following term id by neunhoef · Pull Request #14405 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Following term id #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 7, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e8e551b
First stab at following term id.
neunhoef Jun 25, 2021
79fbdf4
Also handle the planned leader change case.
neunhoef Jun 25, 2021
4fc887c
CHANGELOG.
neunhoef Jun 25, 2021
7c67605
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jun 28, 2021
5be1fd3
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jun 28, 2021
979a956
Remove bug introduced by merge.
neunhoef Jun 28, 2021
df19281
Fix windows compilation issue.
neunhoef Jun 28, 2021
cc931fb
Fix SyncCollectionFinalize.
neunhoef Jun 28, 2021
df4d679
Fix all setTheLeader places.
neunhoef Jun 28, 2021
6aa7a8a
Fix getting in sync.
neunhoef Jun 28, 2021
b66b361
Another try to get configuration of following in shard right.
neunhoef Jun 29, 2021
de5ff72
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jun 29, 2021
304cc67
Apply suggestions from code review
neunhoef Jun 29, 2021
ebf6012
Fix compilation.
neunhoef Jun 29, 2021
0b77428
Improve comments.
neunhoef Jun 29, 2021
45a9336
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jun 30, 2021
8000
8b3e335
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jun 30, 2021
9051010
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jul 1, 2021
aaccae5
Concurrency fixes.
neunhoef Jul 1, 2021
30370c5
Merge branch 'bug-fix/following-term-id' of ssh://github.com/arangodb…
neunhoef Jul 1, 2021
cd3715c
Add test.
neunhoef Jul 1, 2021
e389c23
Merge remote-tracking branch 'origin/devel' into bug-fix/following-te…
neunhoef Jul 5, 2021
d3985e9
Merge branch 'devel' into bug-fix/following-term-id
neunhoef Jul 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix all setTheLeader places.
  • Loading branch information
neunhoef committed Jun 28, 2021
commit df4d679c6c5c9ab91ce320ca15cc0163fc72a535
2 changes: 1 addition & 1 deletion arangod/Cluster/CreateCollection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ bool CreateCollection::first() {
std::vector<std::string> noFollowers;
col->followers()->takeOverLeadership(noFollowers, nullptr);
} else {
col->followers()->setTheLeader(leader);
col->followers()->setTheLeader(LEADER_NOT_YET_KNOWN);
}
}

Expand Down
2 changes: 1 addition & 1 deletion arangod/Cluster/SynchronizeShard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ Result SynchronizeShard::catchupWithExclusiveLock(
}
// If _followingTermid is 0, then this is a leader before the update,
// we tolerate this and simply use its ID without a term in this case.
collection.followers()->setTheLeader(leader);
collection.followers()->setTheLeader(leaderIdWithTerm);
LOG_TOPIC("d76cb", DEBUG, Logger::MAINTENANCE) << "lockJobId: " << lockJobId;

builder.clear();
Expand Down
0