8000 Agency hasAsXXX using std::optional by maierlars · Pull Request #14376 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Agency hasAsXXX using std::optional #14376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 29, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid more bad optional accesses
  • Loading branch information
goedderz committed Jul 6, 2021
commit 16493f586e1f58c94623e891bb97bca29f93e16b
4 changes: 2 additions & 2 deletions arangod/Agency/Supervision.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2416,8 +2416,8 @@ void arangodb::consensus::enforceReplicationFunctional(
bool found = false;
for (auto const& pair : todo) {
auto const& job = pair.second;
auto tmp_type = job->hasAsString("type").value();
auto tmp_shard = job->hasAsString("shard").value();
auto tmp_type = job->hasAsString("type");
auto tmp_shard = job->hasAsString("shard");
if ((tmp_type == "addFollower" || tmp_type == "removeFollower" ||
tmp_type == "moveShard") &&
tmp_shard == shard_.first) {
Expand Down
0