8000 backport rocksdb diskspace bugfix by jsteemann · Pull Request #14354 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

backport rocksdb diskspace bugfix #14354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2021
Merged

backport rocksdb diskspace bugfix #14354

merged 3 commits into from
Jun 19, 2021

Conversation

@jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jun 10, 2021

Scope & Purpose

Backport of #14352

  • Backport bugfix from upstream rocksdb repository for calculating the free disk space for the database directory (rocksdb PR 8370). Before the bugfix, rocksdb could overestimate the amount of free disk space when the arangod process was run as non-privileged users.
  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann
backport rocksdb diskspace bugfix
c566d3c 
* Backport bugfix from upstream rocksdb repository for calculating the
  free disk space for the database directory. Before the bugfix, rocksdb
  could overestimate the amount of free space when the arangod process
  was run as non-privileged users.
@jsteemann jsteemann added this to the 3.7 milestone Jun 10, 2021
@jsteemann jsteemann mentioned this pull request Jun 10, 2021
Merged
8 tasks
fceller
fceller approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor
@fceller fceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 added the 3 RocksDB Storage engine related label Jun 19, 2021
@KVS85 KVS85 merged commit 2181a66 into 3.7 Jun 19, 2021
@KVS85 KVS85 deleted the bug-fix-3.7/backport-rocksdb-diskspace-bugfix branch June 19, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fceller fceller fceller approved these changes

Assignees

@jsteemann jsteemann

Labels

3 RocksDB Storage engine related 9 Ready to Merge

Projects

None yet

Milestone

3.7

Development

Successfully merging this pull request may close these issues.

4 participants

@jsteemann @fceller @KVS85
0