8000 Introduce callstack splitting to avoid stackoverflows with large AQL queries by mpoeter · Pull Request #14351 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Introduce callstack splitting to avoid stackoverflows with large AQL queries #14351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 30, 2021
Merged

Introduce callstack splitting to avoid stackoverflows with large AQL queries #14351

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
23368f8
Introduce callstack splitting to avoid stackoverflows with large AQL …
mpoeter Jun 9, 2021
e1a62d9
Add integration test.
mpoeter Jun 10, 2021
79094ae
Update CHANGELOG.
mpoeter Jun 10, 2021
1018aa9
Fix jslint.
mpoeter Jun 10, 2021
c28d64f
Fix build and add comments.
mpoeter Jun 11, 2021
b30f3b7
Merge branch 'devel' into bug-fix/aql-stackoverflows
jsteemann Jun 15, 2021
ad3c12d
More tests.
mpoeter Jun 15, 2021
8d08d89
Update arangod/RestServer/QueryRegistryFeature.cpp
mpoeter Jun 15, 2021
b90cba3
Fix jslint.
mpoeter Jun 15, 2021
9be14c7
Address review comments.
mpoeter Jun 28, 2021
77cf2da
Fix test.
mpoeter Jun 29, 2021
2d742ae
Merge branch 'devel' into bug-fix/aql-stackoverflows
jsteemann Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix jslint.
  • Loading branch information
@mpoeter
mpoeter committed Jun 15, 2021
commit b90cba35eb1194508fa6ffa1a17d9f66be830ab8
5 changes: 2 additions & 3 deletions tests/js/server/aql/aql-explain-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,16 +212,15 @@ function explainSuite () {

nodes.forEach(function(node) {
assertTrue(node.hasOwnProperty("isCallstackSplitEnabled"));
assertTrue(node.isCallstackSplitEnabled ^ (node.type == "RemoteNode"));
assertTrue(node.isCallstackSplitEnabled ^ (node.type === "RemoteNode"));
});

nodes = AQL_EXPLAIN(query, {}, { maxNodesPerCallstack: 2, verbosePlans: true }).plan.nodes;
print(nodes);
let shouldHaveCallstackSplitEnabled = false;
for (let i = nodes.length; i < 0; --i) {
const node = nodes[i - 1];
assertTrue(node.hasOwnProperty("isCallstackSplitEnabled"));
if (node.type == "RemoteNode") {
if (node.type === "RemoteNode") {
shouldHaveCallstackSplitEnabled = false;
}
assertEqual(shouldHaveCallstackSplitEnabled, node.isCallstackSplitEnabled);
Expand Down
0